Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate Pet Name on Edit Pet #1287

Closed
4313testing opened this issue Jul 10, 2023 · 6 comments
Closed

Duplicate Pet Name on Edit Pet #1287

4313testing opened this issue Jul 10, 2023 · 6 comments

Comments

@4313testing
Copy link

when editing a pet you can put the name of an already existing pet name for the same owner
image
@4313testing
Copy link
Author

@dsyer i can provide the solution in PR if you want

@dsyer
Copy link
Member

dsyer commented Jul 11, 2023

I don’t think it’s worth the extra code, I’m afraid, but I don’t mind if you want to show us how to do it.

@4313testing
Copy link
Author

no problem i am sure you know how to fix it.

@4313testing
Copy link
Author

@dsyer i added the solution in this PR #1288
please check it and see if its helpfull

@dsyer dsyer closed this as completed Jul 12, 2023
@dsyer
Copy link
Member

dsyer commented Jul 12, 2023

I merged it but then the build failed so I reverted. Can you have a look and send another PR please?

@dsyer dsyer reopened this Jul 12, 2023
@4313testing
Copy link
Author

yes it was because of spring-javaformat check
now its fixed you can use this new PR #1290

@dsyer dsyer closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsyer @4313testing