Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing aspectjweaver dependency #44

Closed
stepio opened this issue May 31, 2016 · 4 comments
Closed

Missing aspectjweaver dependency #44

stepio opened this issue May 31, 2016 · 4 comments

Comments

@stepio
Copy link

stepio commented May 31, 2016

Good evening, gentlemen.

Correct me if I'm wrong, but seems that "aspectjweaver" is a mandatory dependency to use spring-retry with annotations.

But when I generated project with spring-retry at "start.spring.io", this dependency was not included. In my opinion it's confusing - annotations are are one of the most common instruments in Spring, so it's seems natural for me to use them.

@garyrussell
Copy link
Contributor

I guess the reasoning is that for users that don't use annotations, the dependency is unnecessary.

Whichever choice is made will cause distress to the other half of users 😄

@stepio
Copy link
Author

stepio commented Jun 1, 2016

That means that as of now the main (recommended) option is not to use annotations. If not, current behaviour spoils the idea of using "start.spring.io" to generate project, which works out of the box.

Maybe it's not an issue for spring-retry itself, but a possible improvement of the above mentioned wizard.

Or you still think that current behaviour is fine as is?

@stepio stepio closed this as completed Jul 9, 2016
@garyrussell
Copy link
Contributor

Sorry for the delay in replying.

You could try opening an issue against the intializr and reference this one - it's not that XML is "preferred" over annotations, just that it's a bit antisocial to pull in an unnecessary dependency for folks that don't need it.

@jonpeterson
Copy link

Could the project be split into two modules? spring-retry and spring-retry-annotations (the later depending on the former)? The annotation module would include the annotations themselves as well as dependencies on the aspectjweaver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants