This repository has been archived by the owner on May 31, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SECOAUTH-332 Add a client filter that can proactively acquire an acce…
…ss token. This new filter would supplement the existing client-side filter that passively checks all incoming requests for required authorization.
- Loading branch information
Showing
2 changed files
with
224 additions
and
0 deletions.
There are no files selected for viewing
162 changes: 162 additions & 0 deletions
162
...ngframework/security/oauth2/client/filter/OAuth2ClientAuthenticationProcessingFilter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
/* | ||
* Copyright 2008 Web Cohesion | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.security.oauth2.client.filter; | ||
|
||
import java.io.IOException; | ||
import java.util.Arrays; | ||
import java.util.Collections; | ||
import java.util.List; | ||
import java.util.Map; | ||
|
||
import javax.servlet.ServletException; | ||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
|
||
import org.springframework.security.authentication.AnonymousAuthenticationToken; | ||
import org.springframework.security.core.Authentication; | ||
import org.springframework.security.core.AuthenticationException; | ||
import org.springframework.security.core.authority.AuthorityUtils; | ||
import org.springframework.security.oauth2.client.OAuth2RestTemplate; | ||
import org.springframework.security.oauth2.client.http.AccessTokenRequiredException; | ||
import org.springframework.security.oauth2.common.OAuth2AccessToken; | ||
import org.springframework.security.oauth2.provider.OAuth2Authentication; | ||
import org.springframework.security.oauth2.provider.authentication.OAuth2AuthenticationManager; | ||
import org.springframework.security.oauth2.provider.token.ResourceServerTokenServices; | ||
import org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter; | ||
import org.springframework.util.Assert; | ||
import org.springframework.util.StringUtils; | ||
import org.springframework.web.client.RestClientException; | ||
import org.springframework.web.client.RestOperations; | ||
|
||
/** | ||
* An OAuth2 client filter that can be used to acquire an OAuth2 access token from an authorization server, | ||
* and load an authentication object into the SecurityContext | ||
* | ||
* @author Vidya Valmikinathan | ||
* | ||
*/ | ||
public class OAuth2ClientAuthenticationProcessingFilter extends AbstractAuthenticationProcessingFilter { | ||
|
||
public RestOperations restTemplate; | ||
|
||
private String userInfoUrl; | ||
|
||
private ResourceServerTokenServices tokenServices; | ||
|
||
/** | ||
* Reference to a CheckTokenServices that can validate an OAuth2AccessToken | ||
* | ||
* @param tokenServices | ||
*/ | ||
public void setTokenServices(ResourceServerTokenServices tokenServices) { | ||
this.tokenServices = tokenServices; | ||
} | ||
|
||
/** | ||
* A rest template to be used to contact the remote user info endpoint. Normally would be an instance of | ||
* {@link OAuth2RestTemplate}, but there is no need for that dependency to be explicit, and there are advantages in | ||
* making it implicit (e.g. for testing purposes). | ||
* | ||
* @param restTemplate a rest template | ||
*/ | ||
public void setRestTemplate(RestOperations restTemplate) { | ||
this.restTemplate = restTemplate; | ||
} | ||
|
||
/** | ||
* The URL of a resource on the remote Authorization Server which provides user profile data. | ||
* Can be used to optionally augment the data available in the OAuth2 token. | ||
* | ||
* @param userInfoUrl | ||
*/ | ||
public void setUserInfoUrl(String userInfoUrl) { | ||
this.userInfoUrl = userInfoUrl; | ||
} | ||
|
||
public OAuth2ClientAuthenticationProcessingFilter(String defaultFilterProcessesUrl) { | ||
super(defaultFilterProcessesUrl); | ||
setAuthenticationManager(new OAuth2AuthenticationManager()); | ||
} | ||
|
||
@Override | ||
public void afterPropertiesSet() { | ||
Assert.state(restTemplate != null, "Supply a rest-template"); | ||
super.afterPropertiesSet(); | ||
} | ||
|
||
@Override | ||
public Authentication attemptAuthentication(HttpServletRequest request, HttpServletResponse response) | ||
throws AuthenticationException, IOException, ServletException { | ||
Map<String, String> userInfo = null; | ||
if (userInfoUrl != null) { | ||
try { | ||
userInfo = restTemplate.getForObject(userInfoUrl, Map.class); | ||
} catch (RestClientException ex) { | ||
userInfo = Collections.emptyMap(); | ||
} | ||
} | ||
|
||
if (restTemplate instanceof OAuth2RestTemplate) { | ||
OAuth2RestTemplate oauth2RestTemplate = ((OAuth2RestTemplate) restTemplate); | ||
OAuth2AccessToken accessToken = oauth2RestTemplate.getAccessToken(); | ||
OAuth2Authentication result = tokenServices.loadAuthentication(accessToken.getValue()); | ||
result.setDetails(userInfo); | ||
return result; | ||
} else { | ||
String username = getUserName(userInfo); | ||
String id = getUserId(userInfo); | ||
AnonymousAuthenticationToken unknownUser = new AnonymousAuthenticationToken(id, username, AuthorityUtils.NO_AUTHORITIES); | ||
unknownUser.setAuthenticated(false); | ||
return unknownUser; | ||
} | ||
|
||
} | ||
|
||
protected String getUserId(Map<String, String> userInfo) { | ||
String id = userInfo.get("id"); | ||
if (!StringUtils.hasText(id)) { | ||
id = userInfo.get("user_id"); | ||
} | ||
return id; | ||
} | ||
|
||
protected String getUserName(Map<String, String> userInfo) { | ||
List<String> options = Arrays.asList("username", "user_name", "login", "screen_name", "email"); | ||
String username = ""; | ||
for (String key : options) { | ||
username = userInfo.get(key); | ||
if (StringUtils.hasText(username)) { | ||
return username; | ||
} | ||
} | ||
return getUserId(userInfo); | ||
} | ||
|
||
@Override | ||
protected void unsuccessfulAuthentication(HttpServletRequest request, HttpServletResponse response, | ||
AuthenticationException failed) throws IOException, ServletException { | ||
if (failed instanceof AccessTokenRequiredException) { | ||
// Need to force a redirect via the OAuth client filter, so rethrow here | ||
throw failed; | ||
} | ||
else { | ||
// If the exception is not a Spring Security exception this will result in a default error page | ||
super.unsuccessfulAuthentication(request, response, failed); | ||
} | ||
} | ||
|
||
} |
62 changes: 62 additions & 0 deletions
62
...amework/security/oauth2/client/filter/TestOAuth2ClientAuthenticationProcessingFilter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
package org.springframework.security.oauth2.client.filter; | ||
|
||
import org.junit.Test; | ||
import static org.junit.Assert.*; | ||
import org.springframework.security.oauth2.client.http.AccessTokenRequiredException; | ||
|
||
import javax.servlet.ServletException; | ||
import java.io.IOException; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
public class TestOAuth2ClientAuthenticationProcessingFilter { | ||
|
||
Map<String, String> userInfo = new HashMap<String, String>(); | ||
OAuth2ClientAuthenticationProcessingFilter filter = new OAuth2ClientAuthenticationProcessingFilter("some-url"); | ||
|
||
public void setUp() { | ||
userInfo = new HashMap<String, String>(); | ||
userInfo.put("id", "user1"); | ||
} | ||
|
||
@Test | ||
public void testGetUserId() { | ||
Map<String, String> userInfo = new HashMap<String, String>(); | ||
assertNull(filter.getUserId(userInfo)); | ||
|
||
userInfo.put("user_id", "userid1"); | ||
assertEquals("userid1", filter.getUserId(userInfo)); | ||
|
||
userInfo.put("id", "id1"); | ||
assertEquals("id1", filter.getUserId(userInfo)); | ||
|
||
userInfo.remove("user_id"); | ||
assertEquals("id1", filter.getUserId(userInfo)); | ||
} | ||
|
||
@Test | ||
public void testGetUserName() { | ||
Map<String, String> userInfo = new HashMap<String, String>(); | ||
assertNull(filter.getUserName(userInfo)); | ||
|
||
userInfo.put("id", "id1"); | ||
assertEquals("id1", filter.getUserName(userInfo)); | ||
|
||
userInfo.put("screen_name", "screen_name"); | ||
userInfo.put("username", "username"); | ||
userInfo.put("user_name", "user_name"); | ||
userInfo.put("login", "login"); | ||
userInfo.put("email", "email"); | ||
assertEquals("username", filter.getUserName(userInfo)); | ||
} | ||
|
||
@Test | ||
public void testUnsuccessfulAuthentication() throws IOException, ServletException { | ||
try { | ||
filter.unsuccessfulAuthentication(null, null, new AccessTokenRequiredException("testing", null)); | ||
fail("AccessTokenRedirectException must be thrown"); | ||
} catch (AccessTokenRequiredException ex) { | ||
|
||
} | ||
} | ||
} |