This repository has been archived by the owner on May 31, 2022. It is now read-only.
Update OAuth2AccessTokenJackson2Deserializer #1173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services use expires_in: 0 to say token never expire
|
@alatushkin Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@alatushkin Thank you for signing the Contributor License Agreement! |
jgrandja
suggested changes
May 8, 2020
There was a problem hiding this comment.
Thanks for the PR @alatushkin. Can you please add a test and we'll get this merged.
| @@ -92,7 +92,7 @@ else if (OAuth2AccessToken.SCOPE.equals(name)) { | |||
|
|
|||
| DefaultOAuth2AccessToken accessToken = new DefaultOAuth2AccessToken(tokenValue); | |||
| accessToken.setTokenType(tokenType); | |||
| if (expiresIn != null) { | |||
| if (expiresIn != null && expiresIn > 0) { | |||
There was a problem hiding this comment.
Hi.
Sure. I'l try to do this in next three days.
jgrandja
added
in: oauth2
status: waiting-for-feedback
type: enhancement
and removed
status: waiting-for-triage
labels
|
Closing in favour of #1862 |
jgrandja
added
status: duplicate
and removed
status: waiting-for-feedback
type: enhancement
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some services use expires_in: 0 to say token never expire
#1172