This repository has been archived by the owner on May 31, 2022. It is now read-only.
Fix reuse refresh token flow #1668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This way reuseRefreshToken not works properly. Every time generates new refresh token. I have resovled issued by removing encode function from refresh token. Is it bad solution? |
|
Hi @RazmikMkrtchyan, @dcoffin pointed out in issue #1109 the spec does in fact say that a new refresh token can be returned on refresh. |
|
Closing this PR. Please see this comment |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1193 #1109
This update fixes an issue with the refresh token flow when the 'reuseRefreshToken' flag is true.
Description of issue:
If the 'reuseRefreshToken' flag is true, and 'supportRefreshToken' flag is true, when refreshing the access token the refresh token changes also(it updates the 'ati' property with the id of the new access token). This new refresh token is referenced against the access token when stored, but the new refresh token itself is not stored, and the original refresh token not being linked to an existing access token. This results in refresh tokens being single use, and being orphaned after use. More information on the issue present in #1193
Fix:
The fix removes the existing refresh token, and stores the new refresh token.