-
Notifications
You must be signed in to change notification settings - Fork 484
SES-18: add support for SAML SOAP binding #32
Comments
Luke Taylor said: Pleas don't open extension issues in the main security project |
Mandus Elfving said: The supplied patch adds support for the SOAP binding (as well as the artifact binding, it still needs an artifact resolution service for outgoing requests and a decoder for incoming requests though) and customizable bindings in the SAMLProcessorImpl class. |
Mandus Elfving said: Patch to add support for the SOAP binding and customizable bindings in the SAMLProcessorImpl class. |
Mandus Elfving said: Updated patch with some small fixes. |
Vladimir Schäfer said: The support for SOAP binding is implemented in the codebase, but the main use-case where this is relevant = Single Logout, requires access to the current user's session which is unavailable (as SOAP calls typically do not include session cookie). For this reason SOAP binding is not included in the generated metadata. I'm leaving the issue opened in case we add a different mechanism which would allow closing of user's session without direct access to it. |
Jeremy Simon said: Hi, I implemented a mechanism for closing out a user's session without direct access to it. I made a registry for Session Indexes and the Authentication objects that is managed as part of login and logout work. So at least my build does SLO pretty well. :) I'd love to contribute it back -- what's the best way? Make a fork of the project? I'm pretty new in Spring stuff, so I'm sure you'd be able to make what I did much better very quickly. I also use WSO2 Identity Server and had patched some short-comings it had. Although, they've fixed a ton of stuff recently and 5.1 and 5.2 will be very agreeable. (SLO with SOAP is coming https://wso2.org/jira/browse/IDENTITY-3578). I'm just mentioning this here because some people seem to encounter much grief with that IDP once they're moving along... there's hope! ;) |
Vladimir Schäfer said: Hi, this would be definitely a welcome contribution. Does your implementation take into account clustered deployments, which is the key pain-point of this feature? The best way to send code is through pull requests in GitHub. |
Jeremy Simon said: I'll make a fork and pull request. It does not take into account clustered deployments right now. It's a thread-safe map under the hood, but I'd like to take it further, just have not. (I actually kept running into a lot of ridiculous things with WSO2 Identity Server that I've been investigating and patching.) The main pain-point probably was just learning someone else's code and paradigm enough to do anything useful. It took a while to find what I could or could not store, and the wheres and whens. :) Hopefully people will be kind. I'm sure this could be made significantly better and thorough! I'll try to get a pull request done in the coming weeks. |
Hello , kind regards. |
Charles Wang (Migrated from SES-18) said:
Currently there is no SOAP binding implemented for the SAML module. So web service clients will not be able to use Spring Security's SAML support.
The text was updated successfully, but these errors were encountered: