Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

SES-28: SAMLAuthenticationProvider should optionally create the AuthenticationToken with the principal containing the UserDetails #35

Closed
spring-projects-issues opened this issue Jan 9, 2010 · 1 comment
Labels
in: core An issue in spring-security-saml-core type: jira An issue that was migrated from JIRA

Comments

@spring-projects-issues
Copy link

Martin Rösel (Migrated from SES-28) said:

I wonder if it would be possible to extend the SAMLAuthenticationProvider so that it optionally would create the AuthenticationToken with the principal containing the UserDetails instead of the String representation of the username.

This feature could be implemented like in the class
org.springframework.security.authentication.dao.AbstractUserDetailsAuthenticationProvider

I have attached my suggestion for the SAMLAuthenticationProvider.

Perhaps you could consider this.

Anyway I would like to thank you Vladimir for contributing your SAML Security Extension to the public.

Martin

@spring-projects-issues
Copy link
Author

Vladimir Schäfer said:

The AbstractUserDetailsAuthenticationProvider was modified to contain method "protected Object getPrincipal(SAMLCredential credential, Object userDetail)" which by default returns NameID from the SAML2 message (as before). You are now free to create Principal in any format (and still keep it different from UserDetails object) by overriding the method.

Signature of method "protected void processUserDetails(AbstractAuthenticationToken token, SAMLCredential credential)" was changed to "protected Object getUserDetails(SAMLCredential credential)".

Hopefully this will solve your issue Martin.

V.

@spring-projects-issues spring-projects-issues added in: core An issue in spring-security-saml-core Closed type: jira An issue that was migrated from JIRA labels Feb 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in: core An issue in spring-security-saml-core type: jira An issue that was migrated from JIRA
Development

No branches or pull requests

1 participant