Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Sample Do not Test Actual Configuration #13

Open
rwinch opened this issue May 25, 2018 · 6 comments
Open

OAuth Sample Do not Test Actual Configuration #13

rwinch opened this issue May 25, 2018 · 6 comments

Comments

@rwinch
Copy link
Member

rwinch commented May 25, 2018

Summary

As it stands the tests that are in Spring Security's OAuth Samples do not test the actual configuration. They are instead copying and modifying the samples to allow testing.

This might seem innocent enough, but we don't want our users to follow this pattern. We need to demonstrate how the existing configuration can be used with perhaps mocking a small piece of the application or running a MockWebServer instance

@jgrandja
Copy link
Contributor

@rwinch I'm not sure I understand the issue with the test(s). Can you please provide more detail.

@jgrandja
Copy link
Contributor

OAuth2LoginApplicationTests currently uses SecurityTestConfig for the integration tests. We should remove SecurityTestConfig so that we're actually testing the WebSecurityConfigurerAdapter that the samples uses.

We also want the integration tests to follow the same pattern as in FormJcTests where pages are defined.

@jgrandja
Copy link
Contributor

@raphaelDL Would you be interested in taking this on?

@raphaelDL
Copy link

sure

@jgrandja jgrandja removed their assignment Jun 4, 2019
@eleftherias
Copy link
Contributor

@raphaelDL have you had a chance to look into this?

@raphaelDL
Copy link

apologies, can someone take over this?

@jgrandja jgrandja transferred this issue from spring-projects/spring-security May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants