-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth Sample Do not Test Actual Configuration #13
Comments
@rwinch I'm not sure I understand the issue with the test(s). Can you please provide more detail. |
We also want the integration tests to follow the same pattern as in |
@raphaelDL Would you be interested in taking this on? |
sure |
@raphaelDL have you had a chance to look into this? |
apologies, can someone take over this? |
Summary
As it stands the tests that are in Spring Security's OAuth Samples do not test the actual configuration. They are instead copying and modifying the samples to allow testing.
This might seem innocent enough, but we don't want our users to follow this pattern. We need to demonstrate how the existing configuration can be used with perhaps mocking a small piece of the application or running a MockWebServer instance
The text was updated successfully, but these errors were encountered: