Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change interface with constants to final class #10960

Closed
jgrandja opened this issue Mar 11, 2022 · 0 comments
Closed

Change interface with constants to final class #10960

jgrandja opened this issue Mar 11, 2022 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release
Milestone
6.0.0-M6

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Mar 11, 2022 •
edited

We should change interface that define constants only to public final class (same as JoseHeaderNames).

This change should be applied to the following:

  • JwtClaimNames
  • IdTokenClaimNames
  • StandardClaimNames
  • OAuth2ParameterNames
  • PkceParameterNames
  • OAuth2TokenIntrospectionClaimNames
  • OidcParameterNames
  • Saml2ParameterNames
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release labels Mar 11, 2022
@jgrandja jgrandja self-assigned this Mar 11, 2022
@jgrandja jgrandja added this to the 6.0.x milestone Mar 11, 2022
@jgrandja jgrandja modified the milestones: 6.0.x, 6.0.0-M6 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release
Projects
Spring Security Team
Status: Done
Milestone
6.0.0-M6
Development

No branches or pull requests
1 participant
@jgrandja