Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extendend SAML logging (like SAMLDefaultLogger) #11592

Open
Tracked by #6311
habizzle opened this issue Jul 18, 2022 · 4 comments
Open
Tracked by #6311

Provide extendend SAML logging (like SAMLDefaultLogger) #11592

habizzle opened this issue Jul 18, 2022 · 4 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules status: feedback-provided Feedback has been provided type: enhancement A general enhancement

Comments

@habizzle
Copy link

Expected Behavior

We would like to have the possibility to easily log SAML responses as with the (previous) SAMLLogger-API.

Current Behavior

We did not find a "standard" way of logging details of the SAML response.

Context

We are currently migrating from Spring Security SAML Extension to the new Spring Security Service Provider library. We have used a SAMLDefaultLogger bean to have an extensive logging of the SAML response (e.g. in the old SAMLAuthenticationProvider).
In the new library we did not find something like the old SAMLLogger-API and in the new OpenSamlAuthenticationProvider, the logger does only log pretty basic information.

Are you planning to port this feature or do you recommend overriding e.g. the AuthenticationProvider for adding more logging?
Thanks!

@habizzle habizzle added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jul 18, 2022
@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 18, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jul 18, 2022

do you recommend overriding e.g. the AuthenticationProvider for adding more logging?

Hi, @habizzle. Can you tell me more about what you are trying to do? I ask since it's not clear to me how introducing a logging component will change the log detail level.

only log pretty basic information

Should the authentication provider log more advanced information and if so, where? If you and I can come to an agreement on that, the best solution could be a PR so that everyone gets the benefit of additional detail.

@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Jul 25, 2022
@mjanczykowski
Copy link

mjanczykowski commented Jul 26, 2022

The old library allowed to log full SAML requests and responses to server logs. It was useful for investigating issues with SAML login reported by customers (in my case we integrate with our customer's Identity Providers).

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Jul 26, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jan 9, 2023

Sorry for the delay, @mjanczykowski. I think adding requests and responses to trace logging sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules status: feedback-provided Feedback has been provided type: enhancement A general enhancement
Projects
Status: No status
Development

No branches or pull requests

4 participants