Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend AuthorizationChannelInterceptor for postReceive() implementation #11915

Open
artembilan opened this issue Sep 28, 2022 · 2 comments
Open
Assignees
Labels
in: messaging An issue in spring-security-messaging status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Comments

@artembilan
Copy link
Member

Expected Behavior

The AuthorizationChannelInterceptor implements a similar to the preSend() in the postReceive() contract which is applicable for the PollableChannel implementations.

Current Behavior

The AuthorizationChannelInterceptor currently implements only preSend() for decision to put a Message<?> onto the MessageChannel or not.

Context

Not all MessageChannel implementations are just SubscribableChannel, there is a PollableChannel which is implemented in Spring Integration as a QueueChannel.
With this channel there is no direct connection between producer and consumer. A QueueChannel is polled by the TaskScheduler.
So, we need to be secured on that receiving side against messages we poll from the channel.
This will lead to a proper messaging security support in Spring Integration applications.

@artembilan
Copy link
Member Author

Any news on this?
Will it make in time for upcoming RC release cycle in a couple weeks?
Or should I start looking into this as an interim home-made solution?

Thank you!

@artembilan
Copy link
Member Author

See the fix I propose for Spring Integration for current situation: spring-projects/spring-integration#3915.

It looks like the ExpressionBasedAuthorizationManager has to be promoted to the top-level class as well.

@jzheaux jzheaux added this to the 6.1.0-M1 milestone Oct 24, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 6.1.0-M1, 6.1.0-M2 Jan 16, 2023
@jzheaux jzheaux removed this from the 6.1.0-M2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging An issue in spring-security-messaging status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
Status: No status
Development

No branches or pull requests

4 participants