Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure DefaultSecurityFilterChain logs #12218

Open
Tracked by #6311
jzheaux opened this issue Nov 16, 2022 · 2 comments
Open
Tracked by #6311

Restructure DefaultSecurityFilterChain logs #12218

jzheaux opened this issue Nov 16, 2022 · 2 comments
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 16, 2022

DefaultSecurityFilterChain prints out at the INFO level the list of filters that are in use for a given application. This is out of step with FilterChainProxy which shows that level of detail at the DEBUG and TRACE levels.

It may be valuable to show something here at the INFO level, like the request matcher and the authentication mechanisms. Otherwise, this level of detail should be reserved to DEBUG or TRACE.

Also, it probably doesn't add value to print out the filter's toString. Instead, it may be better to only print out the class name.

@jzheaux jzheaux mentioned this issue Nov 16, 2022
7 tasks
@jzheaux jzheaux changed the title Restructure SecurityFilterChain logs Restructure DefaultSecurityFilterChain logs Nov 16, 2022
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 22, 2022
@jzheaux jzheaux added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jan 5, 2023
@jzheaux jzheaux self-assigned this Jan 11, 2023
@awydini
Copy link

awydini commented Jan 18, 2023

Hi @jzheaux
can I work on this?

@jzheaux
Copy link
Contributor Author

jzheaux commented Jan 24, 2023

Yes, @awydini, it's yours.

@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
Status: No status
Development

No branches or pull requests

2 participants