Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should show underlying Client Authentication method #13496

Closed
jzheaux opened this issue Jul 12, 2023 · 0 comments
Closed

Error message should show underlying Client Authentication method #13496

jzheaux opened this issue Jul 12, 2023 · 0 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jul 12, 2023

The error message:

This class supports client_secret_basic, client_secret_post, and none by default. Client [%s] is using [%s] instead. Please use a supported client authentication method, or use setRequestEntityConverter to supply an instance that supports [%s].

renders like this:

This class supports client_secret_basic, client_secret_post, and none by default. Client [salesforce-client] is using [org.springframework.security.oauth2.core.ClientAuthenticationMethod@3b4abc2b] instead. Please use a supported client authentication method, or use setRequestEntityConverter to supply an instance that supports [org.springframework.security.oauth2.core.ClientAuthenticationMethod@3b4abc2b]

This would be more informative if it showed the actual client authentication method value instead of the instance reference.

Related to #13476

@jzheaux jzheaux added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 12, 2023
@jzheaux jzheaux self-assigned this Jul 12, 2023
@jzheaux jzheaux added this to the 6.0.5 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant