Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-1439: getRequest() / getResponse() is not public in org.springframework.security.web.context.HttpRequestResponseHolder #1682

Closed
spring-issuemaster opened this issue Mar 11, 2010 · 1 comment

Comments

@spring-issuemaster
Copy link

@spring-issuemaster spring-issuemaster commented Mar 11, 2010

Lukas Herman (Migrated from SEC-1439) said:

Custom SecurityContextRepository implementation relies on HttpRequestResponseHolder parameter in method
public SecurityContext loadContext(HttpRequestResponseHolder requestResponseHolder).

Since getters and setters of HttpRequestResponseHolder properties are not public, pluggable repository mechanism is broken.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Mar 12, 2010

Luke Taylor said:

Yes, thanks for pointing this out. I've made the changes in the 3.0.x and master branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.