Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-31: Consider returning a Vote object in AccessDecisionVoter interface #296

Closed
spring-projects-issues opened this issue Jul 4, 2005 · 1 comment
Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Milestone

Comments

@spring-projects-issues
Copy link

Ben Alex(Migrated from SEC-31) said:

As per Keith’s suggestion, consider returning a Vote object instead of ints, such that a reason for a decline vote can be given for UI display.

@spring-projects-issues
Copy link
Author

Ben Alex said:

Creating an AccessDeniedException is the responsibility of the AccessDecisionManager, not the AccessDecisionVoter. A complicating factor is if multiple votes to grant and deny are received concurrently – what should the exception message comprise?

A solution might be to develop an AccessDecisionManager that can accept a list of AccessDecisionVoters, together with a message code (for lookup from a resource bundle) that is used in the event of a vote to deny access. The deny access votes could then be concatenated into the exception text. This approach avoids the need to break backward compatibility by modifying the existing integer-based voting mechanism.

@spring-projects-issues spring-projects-issues added in: core An issue in spring-security-core Closed type: enhancement A general enhancement status: declined A suggestion or change that we don't feel we should currently apply type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@spring-projects-issues spring-projects-issues added this to the 0.9.0 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Development

No branches or pull requests

2 participants
@spring-projects-issues and others