Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<concurrency-control> support for unlimited sessions #3899

Closed
michael-simons opened this issue May 24, 2016 · 4 comments
Closed

<concurrency-control> support for unlimited sessions #3899

michael-simons opened this issue May 24, 2016 · 4 comments
Assignees
@rwinch
Labels
in: web An issue in web modules (web, webmvc)
Milestone
4.2.0 M1

Comments

@michael-simons
Copy link
Contributor

Summary

I want to use concurrency-control inside xml configuration, mainly to use session registry, without limiting number of sessions.

ConcurrentSessionControlAuthenticationStrategy states in #setMaximumSessions "The default value is 1. Use -1 for unlimited sessions.".

Actual Behavior

Cannot configure max-sessions="-1" because value is a positive integer in XSD, parsing fails.

Expected Behavior

<concurrency-control max-sessions="-1" />

Is a valid configuration.

Version

4.1.0.RELEASE and lower.
@michael-simons michael-simons mentioned this issue May 24, 2016
Closed
1 task
@rwinch
Copy link
Member

rwinch commented May 24, 2016

Thanks for the PR!

Any reason you can't just skip configuring it all together?

@rwinch rwinch added the status: waiting-for-feedback We need additional information before we can continue label May 24, 2016
@michael-simons
Copy link
Contributor Author

Hi Rob,
I want to be able to use the session registry and configuring concurrency control is the most convenient way I found. Thanks.

@rwinch rwinch removed the status: waiting-for-feedback We need additional information before we can continue label Jun 22, 2016
@rwinch rwinch added this to the 4.2.0 M1 milestone Jun 22, 2016
@rwinch
Copy link
Member

rwinch commented Sep 21, 2016

Thanks again for submitting this issue (and the PR). This is resolved via #3900 (comment)

@rwinch rwinch closed this as completed Sep 21, 2016
@rwinch rwinch self-assigned this Sep 21, 2016
@rwinch rwinch added Namespace in: web An issue in web modules (web, webmvc) labels Sep 21, 2016
@michael-simons
Copy link
Contributor Author

👍🏻

@rwinch rwinch changed the title It's not possible to configure unlimited number of sessions when using xml config / concurrency-control <concurrency-control> support for unlimited sessions Sep 23, 2016
@rwinch rwinch removed in: config An issue in spring-security-config Namespace labels May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc)
Projects
None yet
Milestone
4.2.0 M1
Development

Successfully merging a pull request may close this issue.

Allow negative values to configure unlimited sessions michael-simons/spring-security
2 participants
@rwinch @michael-simons