<concurrency-control> support for unlimited sessions #3899

Closed
michael-simons opened this Issue May 24, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@michael-simons
Contributor

michael-simons commented May 24, 2016

Summary

I want to use concurrency-control inside xml configuration, mainly to use session registry, without limiting number of sessions.

ConcurrentSessionControlAuthenticationStrategy states in #setMaximumSessions "The default value is 1. Use -1 for unlimited sessions.".

Actual Behavior

Cannot configure max-sessions="-1" because value is a positive integer in XSD, parsing fails.

Expected Behavior

<concurrency-control max-sessions="-1" />

Is a valid configuration.

Version

4.1.0.RELEASE and lower.

@rwinch

This comment has been minimized.

Show comment
Hide comment
@rwinch

rwinch May 24, 2016

Member

Thanks for the PR!

Any reason you can't just skip configuring it all together?

Member

rwinch commented May 24, 2016

Thanks for the PR!

Any reason you can't just skip configuring it all together?

@michael-simons

This comment has been minimized.

Show comment
Hide comment
@michael-simons

michael-simons May 25, 2016

Contributor

Hi Rob,
I want to be able to use the session registry and configuring concurrency control is the most convenient way I found. Thanks.

Contributor

michael-simons commented May 25, 2016

Hi Rob,
I want to be able to use the session registry and configuring concurrency control is the most convenient way I found. Thanks.

@rwinch rwinch added this to the 4.2.0 M1 milestone Jun 22, 2016

@rwinch

This comment has been minimized.

Show comment
Hide comment
@rwinch

rwinch Sep 21, 2016

Member

Thanks again for submitting this issue (and the PR). This is resolved via #3900 (comment)

Member

rwinch commented Sep 21, 2016

Thanks again for submitting this issue (and the PR). This is resolved via #3900 (comment)

@rwinch rwinch closed this Sep 21, 2016

@rwinch rwinch self-assigned this Sep 21, 2016

@michael-simons

This comment has been minimized.

Show comment
Hide comment
@michael-simons

michael-simons Sep 21, 2016

Contributor

👍🏻

Contributor

michael-simons commented Sep 21, 2016

👍🏻

@rwinch rwinch changed the title from It's not possible to configure unlimited number of sessions when using xml config / concurrency-control to <concurrency-control> support for unlimited sessions Sep 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment