Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML: Document how to change validation for audiences when using example IssuerSaml2AuthenticationRequestFactory #8320

Open
Primedo opened this issue Apr 3, 2020 · 0 comments
Open

SAML: Document how to change validation for audiences when using example IssuerSaml2AuthenticationRequestFactory #8320

Primedo opened this issue Apr 3, 2020 · 0 comments
Assignees
@jzheaux
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement

Comments

@Primedo
Copy link

Primedo commented Apr 3, 2020

Summary

The documentation shows as example IssuerSaml2AuthenticationRequestFactory on how to get "more control", but it does not show, how to update the validation for SAML2AssertionValidationParameters.COND_VALID_AUDIENCES when the IdP uses the "calculated" issuer as audience.

https://github.com/spring-projects/spring-security/blob/master/docs/manual/src/docs/asciidoc/_includes/servlet/saml2/saml2-login.adoc

Expected Behavior

Updated documentation.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 3, 2020
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 6, 2020
@jzheaux jzheaux added this to the 5.4.x milestone Apr 6, 2020
@jzheaux jzheaux added in: docs An issue in Documentation or samples and removed in: saml2 An issue in SAML2 modules labels Apr 14, 2020
@jgrandja jgrandja modified the milestones: 5.4.x, 5.5.x Sep 9, 2020
@rwinch rwinch removed this from the 5.5.x milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rwinch @Primedo @jzheaux @jgrandja @spring-projects-issues