Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @NonNullApi for null-safety #8389

Open
pkubowicz opened this issue Apr 14, 2020 · 0 comments
Open

Use @NonNullApi for null-safety #8389

pkubowicz opened this issue Apr 14, 2020 · 0 comments
Assignees
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement

Comments

@pkubowicz
Copy link

Summary

Use @NonNullApi annotation as Spring Core did.

Actual Behavior

Many parts of the API like ClaimAccessor return null, so it's easy to cause NPE if you don't read JavaDoc carefully.

Expected Behavior

Use @NonNullApi and @Nullable at least for part of the API.

Configuration

Version

All versions up to today's master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
Status: No status
Development

No branches or pull requests

4 participants