Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Shell log file location not changed #478

Closed
ateequrrahman97 opened this issue Jul 20, 2022 · 10 comments
Closed

Spring Shell log file location not changed #478

ateequrrahman97 opened this issue Jul 20, 2022 · 10 comments

Comments

@ateequrrahman97
Copy link

Hi @ericbottard,
I hope you are doing good

I have added these two lines in my properties file to change the spring shell log file location but it does not create/save in my desired location and file.
It saves on the root of the project directory with my project name.

spring.shell.config.location=./logs
spring.shell.history.name=shell-command.log

Here is the Reference link Spring Shell History

@jvalkeal
Copy link
Contributor

This feels like regression. We'll take a look.

@nad33mahm3d
Copy link

nad33mahm3d commented Jul 20, 2022

I am also facing the same issue. I am using below dependency

<dependency>
<groupId>org.springframework.shell</groupId>
<artifactId>spring-shell-starter</artifactId>
<version>2.0.1.RELEASE</version>
</dependency>

@jvalkeal
Copy link
Contributor

@ateequrrahman97 can you tell spring shell version?

@ateequrrahman97
Copy link
Author

@ateequrrahman97 can you tell the spring shell version?

@jvalkeal yes
Its
2.0.1.RELEASE

@jvalkeal
Copy link
Contributor

Right you referenced 2.1.0-SNAPSHOT docs so it should work there.

@ateequrrahman97
Copy link
Author

ateequrrahman97 commented Jul 21, 2022

Right you referenced 2.1.0-SNAPSHOT docs so it should work there.

But On maven, there are only two versions available Spring Shell Starter!
Mavan Repository

And 2.1.0-SNAPSHOT does not load on maven reload and gives me an error.

Unresolved dependency: 'org.springframework.shell:spring-shell-starter:jar:2.1.0-SNAPSHOT'
Dependency 'org.springframework.shell:spring-shell-starter:2.1.0-SNAPSHOT' not found

@ateequrrahman97
Copy link
Author

Right you referenced 2.1.0-SNAPSHOT docs so it should work there.
Hi @jvalkeal

I have created a new project but face the same issue.

Dependency 'org.springframework.shell:spring-shell-starter:2.1.0-SNAPSHOT' not found

@jvalkeal
Copy link
Contributor

That's because 2.1.0 is not yet released(milestones and snapshots only available from spring repos). Just about to do it by next week.

@ateequrrahman97
Copy link
Author

ateequrrahman97 commented Jul 22, 2022

That's because 2.1.0 is not yet released(milestones and snapshots only available from spring repos). Just about to do it by next week.

Thanks @jvalkeal
So do not close the issue until the new release.
And it would be great if you comment here after the new release. So we can test with new release and verfy new chanfges.

@jvalkeal
Copy link
Contributor

@ateequrrahman97 2.1.0 is out and in maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants