New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added converters.ObjectConverter and converters.ArrayConverter #9
Conversation
…ArrayConverter. Added "objects" sample application. The "objects" sample shows usage of ObjectResolver, ObjectConverter and ArrayConverter. ArrayConverter uses reflection and throws an Error if it is used but Java 6 is not available.
Any chance of getting this merged and released in the foreseeable future? |
Created SHL-109 - Add converters.ObjectConverter and converters.ArrayConverter to complete aribitrary instances referencing this pull request. |
just getting around to it.... |
Closing, will address array/collection with https://jira.spring.io/browse/SHL-173 (which should be automatic) |
There is no coupling with any DAO. |
Thanks for breaking my code with the latest 1.2.0 release. 👍 |
Also thanks for zero documentation in either the Spring Shell Documentation or the javadoc of Keep up the tremendous work. 👍 |
Hi. This project is really at a minimal level of support on our side, that is the reality. I appreciate the PRs and know it is going way back to 2013. so yea, it is just basic neglect on our side, I accept responsibility. The sarcasm is certainly not appreciated as we are indeed trying our best here. |
You don't have to upgrade to the latest version of Spring Shell. Moreover, |
Sorry about the sarcasm. I'm usually not like that, especially not while interacting with open source projects. But the way this was handled really annoyed me. It's not so much that the reaction time was slow but about the way the PR was shot down. My PR...
My implementation supported two options in Supporting the The "too much complexity" is due to this added functionality. The code of the pull request has been in production for years and has never required any fix. And both of those options have been very useful, too. The only "coupling with DAO" in my code is the comment " All of this gives me the impression that you didn't give my PR more than a casual glance before deciding that you'd rather implement something yourself. I especially think that not including a sample application would have vastly increased my chance of getting this applied - which is just sad. Regarding the documentation of
I was obviously able to upgrade to
Because of that, there have been several other things we've added in the meantime that could have been interesting for This includes stuff like...
I hope the irony of having a project "at a minimal level of support" and not caring for third-party contributions is not lost on you. While it certainly appears to be true that this project is "at a minimal level of support", this isn't mentioned anywhere either. Which means that the way this issue/PR was handled is assumed for And this isn't a theory but just a plain fact regarding myself and all of my coworkers. |
Added "objects" sample application.
The "objects" sample shows usage of ObjectResolver, ObjectConverter and ArrayConverter.
Added ObjectConverterTest and ArrayConverterTest.
ArrayConverter uses reflection and throws an Error if it is used but Java 6 is not available.