Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Retry mechanism for vault template #504

Open
worldtiki opened this issue Nov 8, 2019 · 1 comment
Open

Request: Retry mechanism for vault template #504

worldtiki opened this issue Nov 8, 2019 · 1 comment
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@worldtiki
Copy link

Hi 馃憢

I saw this first asked in stackoverflow.

This seems fairly common and a normal thing to have (retries) but all the alternatives to implement this are very cumbersome.
With the advent of service meshes I believe this will become even more necessary as a common issue when using these are race conditions between our Spring application and the service mesh proxy which can cause the Spring app to fail to start.

I think having something like spring.cloud.vault.something.retries=3 would be a more convenient way to do this and a much welcomed feature by users of Spring Vault.

I'm happy to draft a pr if there is interest.

@mp911de mp911de added the status: waiting-for-triage An issue we've not yet triaged label Nov 9, 2019
@kgunnerud
Copy link

Would be neat.

From time to time, we get a ConnectionReset or something similar, which does not pose a problem since its the health check, but as we have metrics on health checks this creates an alert. Network faults will happen, although not often. So having some kind of retry on operations that leave your application would not be totally insane?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants