Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme update #1145

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Readme update #1145

merged 2 commits into from
Apr 23, 2021

Conversation

debargharoy
Copy link
Contributor

Update readme to better organize contents and add a table of contents.

bnasslahsen
bnasslahsen approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@bnasslahsen bnasslahsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @debargharoy for your contribution.

@bnasslahsen bnasslahsen merged commit a3b2472 into springdoc:master Apr 23, 2021
@debargharoy debargharoy deleted the readme-update branch April 23, 2021 09:44
@debargharoy
Copy link
Contributor Author

I assume the PRs are now being merged with a merge commit.

I was thinking if we should only keep the Squash and Merge option for merging PRs. That way, we can keep the number of commits less on the master branch and not carry over multiple smaller commits from the feature branch as shown below
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnasslahsen bnasslahsen bnasslahsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@debargharoy @bnasslahsen