Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting oauth2RedirectUrl does not respect relaxed binding #591

Closed
maciejwalkowiak opened this issue Apr 21, 2020 · 0 comments
Closed

Setting oauth2RedirectUrl does not respect relaxed binding #591

maciejwalkowiak opened this issue Apr 21, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@maciejwalkowiak
Copy link

Describe the bug

Setting property springdoc.swagger-ui.oauth2-redirect-url does not work.

Expected behavior

Setting property springdoc.swagger-ui.oauth2-redirect-url should have exactly same result as setting springdoc.swagger-ui.oauth2RedirectUrl.

Additional context

springdoc.swagger-ui.oauth2RedirectUrl maps to SwaggerUiConfigProperties#oauth2RedirectUrl where SwaggerUiConfigProperties is a Spring Boot @ConfigurationProperties class. @ConfigurationProperties classes support relaxed binding, meaning properties can be set by one of:

  • springdoc.swagger-ui.oauth2RedirectUrl
  • springdoc.swagger-ui.oauth2-redirect-url

The latter is syntax that is generated by spring-boot-configuration-processor from Spring Boot, thus it's the syntax that will be autocompleted in IDEs supporting spring-configuration-metadata.json files.

Springdoc refers to this property springdoc.swagger-ui.oauth2RedirectUrl through @Value annotation in AbstractSwaggerWelcome ignoring the same time possibility to set same property through springdoc.swagger-ui.oauth2-redirect-url.

@bnasslahsen bnasslahsen added the enhancement New feature or request label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants