Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "performance" section #180

Closed
hollsk opened this issue Jun 26, 2017 · 5 comments · Fixed by #185
Closed

Add a "performance" section #180

hollsk opened this issue Jun 26, 2017 · 5 comments · Fixed by #185
Assignees

Comments

@hollsk
Copy link
Contributor

hollsk commented Jun 26, 2017

I propose a "performance" section to contain the following existing files:

  • advertising
  • images
  • graded browser support
  • progressive enhancement

Is this idea awesome Y/N?

@jpw
Copy link
Contributor

jpw commented Jun 27, 2017

Is this idea awesome Y/N?

@tulipdexter
Copy link
Contributor

I'm not sure I'd instinctively think about graded browser support and progressive enhancement as being under the umbrella of 'performance'.

@hollsk
Copy link
Contributor Author

hollsk commented Jun 28, 2017

Yeah, i had the same thought @davidpauljunior - but I couldn't think of anything more appropriate.

  • They don't belong in markup or accessibility
  • Both are distinct (& related) technical approaches, but they're not really architecture, exactly

Can you think of a category they could be contained by?

@jpw
Copy link
Contributor

jpw commented Jun 29, 2017

general concencus here to leave everything in the root unless > 1 related thing, then folder

don't know if this answers the question lol

@hollsk
Copy link
Contributor Author

hollsk commented Jun 29, 2017

As per catchup:

  • everyone agrees that GBS and PE don't strictly belong in performance
  • we agreed that it's fine to leave pages uncategorised if there's no logical grouping
  • general decision made to leave everything in the root unless > 1 related thing, then folder

@hollsk hollsk self-assigned this Jun 29, 2017
@hollsk hollsk mentioned this issue Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants