Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Links URLs #66

Closed
Michael-A-Sherman opened this issue Nov 4, 2019 · 3 comments
Closed

Quick Links URLs #66

Michael-A-Sherman opened this issue Nov 4, 2019 · 3 comments

Comments

@Michael-A-Sherman
Copy link

Hello,

I ran into an issue with the quick link urls that I think could be fixed quite easily. I was running this on a VM and when I pulled up the IP of the VM on a different machine on my network, the quick links did not work because the quick links use local host.

<li><a href="http://localhost/phpinfo.php">phpinfo()</a></li>
<li><a href="http://localhost:8080">phpMyAdmin</a></li>
<li><a href="http://localhost/test_db.php">Test DB Connection</a></li>

I feel like this could easily be resolved by changing the links as follows:

<li><a href="/phpinfo.php">phpinfo()</a></li>
<li><a href="//<?php print $_SERVER{'SERVER_NAME'}; ?>:8080">phpMyAdmin</a></li>
<li><a href="/test_db.php">Test DB Connection</a></li>

I would be happy to submit a PR if this is ok.

Thank you

@MrOffline77
Copy link
Collaborator

Hi @tsh3rman ,
thank your for you participation ! Please feel free to create a pull request for each php version branch.

@Michael-A-Sherman
Copy link
Author

I submitted a pull request on each branch.

@MrOffline77
Copy link
Collaborator

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants