Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setter of some properties doesn't works #9

Closed
thoretton-edwin opened this issue Jan 16, 2017 · 8 comments
Closed

Setter of some properties doesn't works #9

thoretton-edwin opened this issue Jan 16, 2017 · 8 comments
Assignees
Labels

Comments

@thoretton-edwin
Copy link

Trying to update sliderCircleRadius, trackCircleRadius and trackHeight properties cause a issue .Slider view do not appears on subview after setting properties

PS : the corresponding getters works fine

@spromicky spromicky self-assigned this Jan 16, 2017
@spromicky spromicky added the bug label Jan 16, 2017
@spromicky
Copy link
Owner

Hmmm... Really strange behaviour. Will be great if you share some code example of your usage. And version of StepSlider.

@thoretton-edwin
Copy link
Author

Hi, i do some tests : I was wrong about getter methods issue, the problem on my project is the the component frame. If the width is lesser than 240.0f, the component does not appears. An code example below :
`
CGRect validRect = CGRectMake(10.f, 240.f, 300.f, 44.f);

CGRect invalidRect = CGRectMake(10.f, 200.f, 239.f, 44.f);

StepSlider *slider = [[StepSlider alloc] initWithFrame:invalidRect];

[slider setBackgroundColor:[UIColor grayColor]];
[slider setMaxCount:4];
[slider setIndex:1];
[slider setAdjustLabel:YES];
[slider setLabels:@[@"0", @"25", @"50", @"100"]];
[slider setLabelColor:[UIColor darkTextColor]];
[slider setDotsInteractionEnabled:YES];
[slider setSliderCircleRadius:slider.sliderCircleRadius];
[slider setTrackCircleRadius:slider.trackCircleRadius];
[slider setTrackHeight:slider.trackHeight];
[self.view addSubview:slider];

`

PS : I'm on StepSlider 1.0.0 version

@spromicky
Copy link
Owner

I've tried your code and StepSlider still appears. But I've found some frame issue. I fixed this. Hope its also will fix your case. I wanna wait before push it as new version. Just wait maybe someone will find another bug. So i ask your test please, that code from master, and will write your result here.

@spromicky
Copy link
Owner

Push new version to CocoaPods.

@csotiriou
Copy link

After updating to version 1.0.x from 0.1.x, I am also seeing strange behaviour. There are some widths in which the slider will not appear at all.

I am using 1.0.1

@spromicky
Copy link
Owner

@csotiriou, can you provide more details? What iOS, how you use StepSlider? Will be great if you make pull request with example, when this behaviour reproduced.

@perteadrian
Copy link

I also have this problem. I added to my Swift project via Cocoapods. When I first installed the framework it didn't show in storyboard or in the testing device. I kept messing around with the visual proprieties and finally got it to work. Then I send a commit to my repo on Github and now it's again missing.

@spromicky
Copy link
Owner

Hope I fixed it in 1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants