Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Automatic dark mode triggering #178

Conversation

alirezadizaji
Copy link

Hi,

I implemented a feature to enable triggering dark mode automatically by developing a workflow. Beforehand, users should set a variable called trigger_darkmode, which by default is null meaning to disable this feature. If not null, then this variable should contain two keys: start_light and start_dark, indicating the hour to start light and dark mode respectively. Both should have the HH format.

@sproogen
Copy link
Owner

sproogen commented Apr 5, 2023

I think this is probably a bit of an overkill for triggering darkmode on a schedule. A simpler approach would be checking the status in the browser instead of a cron job to update the config and re deploy.
But I think keeping a static option for dark mode is fine for now.

@sproogen sproogen closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants