Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darkmode: true obscures email address #95

Closed
garethtalty opened this issue Mar 15, 2020 · 1 comment · Fixed by #96
Closed

darkmode: true obscures email address #95

garethtalty opened this issue Mar 15, 2020 · 1 comment · Fixed by #96

Comments

@garethtalty
Copy link
Contributor

garethtalty commented Mar 15, 2020

Describe the bug
When darkmode: true is enabled, all elements are given a background color, meaning email contact info is obscured by the 'fork me on GitHub' banner at certain resolutions.

To Reproduce
Steps to reproduce the behavior:

  1. Add darkmode: true to _config.yml
  2. Navigate to the hosted resume in a browser with dark mode enabled
  3. Reduce screen resolution to 1280px width
  4. Observe obscured email contact details as per screen-grab below.

Expected behavior
Email contact info is displayed unobscured

Screenshots
Screen Shot 2020-03-15 at 13 59 04
Screen Shot 2020-03-15 at 13 59 12

Desktop (please complete the following information):

  • OS: Mac OS 10.13.6
  • Browser: chrome
  • Version 80.0
@sproogen
Copy link
Owner

sproogen commented Mar 15, 2020

I only added the forkme banner for the test repo, it's not meant be on everyone's resumes 😂 But it seems like a lot of people fork the main repo instead of the starting point codebase linked in the readme.

Removing the wildcard is probably the right thing anyways, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants