Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC.View#touchBoundary appears to be ignored by touchIsInBoundary #826

Closed
dcporter opened this issue Sep 6, 2012 · 2 comments
Closed

SC.View#touchBoundary appears to be ignored by touchIsInBoundary #826

dcporter opened this issue Sep 6, 2012 · 2 comments
Milestone

Comments

@dcporter
Copy link
Member

dcporter commented Sep 6, 2012

In core_foundation/views/view/touch.js, the touchIsInBoundary method pulls in the touchBoundary property, does some very nice calculations with it, and then appears to ignore it at the last second:

    if (x > 100 || y > 100) return NO;
    return YES;

Note to self (or anyone with an itch to get unit-testin'): fix this.

@dcporter
Copy link
Member Author

dcporter commented Sep 6, 2012

Also: refactor this to use SC.pointInRect, rather than rewriting that code here. (Thanks @publickeating.)

@publickeating
Copy link
Member

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants