Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

SC.View#touchBoundary appears to be ignored by touchIsInBoundary #826

Closed
dcporter opened this Issue · 2 comments

2 participants

Dave Porter Tyler Keating
Dave Porter
Owner

In core_foundation/views/view/touch.js, the touchIsInBoundary method pulls in the touchBoundary property, does some very nice calculations with it, and then appears to ignore it at the last second:

    if (x > 100 || y > 100) return NO;
    return YES;

Note to self (or anyone with an itch to get unit-testin'): fix this.

Dave Porter
Owner

Also: refactor this to use SC.pointInRect, rather than rewriting that code here. (Thanks @publickeating.)

Tyler Keating

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.