SC.View#touchBoundary appears to be ignored by touchIsInBoundary #826

Closed
dcporter opened this Issue Sep 6, 2012 · 2 comments

Projects

None yet

2 participants

@dcporter
Owner
dcporter commented Sep 6, 2012

In core_foundation/views/view/touch.js, the touchIsInBoundary method pulls in the touchBoundary property, does some very nice calculations with it, and then appears to ignore it at the last second:

    if (x > 100 || y > 100) return NO;
    return YES;

Note to self (or anyone with an itch to get unit-testin'): fix this.

Owner
dcporter commented Sep 6, 2012

Also: refactor this to use SC.pointInRect, rather than rewriting that code here. (Thanks @publickeating.)

Owner

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment