Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Use a Selector (NIO), rather than a thread per connection #21

Closed
lmprice opened this issue Jan 14, 2019 · 1 comment
Closed

Comments

@lmprice
Copy link

lmprice commented Jan 14, 2019

I would like to see the Connection utilize a Selector and a single thread rather than unique reader threads per connection/socket. This will make the library work a lot better when scaling up the number of Topics/Channels being utilized.

I am willing to make/submit this change as a PR.

@robseed
Copy link
Contributor

robseed commented Jan 31, 2019

We spoke over email. Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants