This repository has been archived by the owner on Apr 5, 2023. It is now read-only.
Node simpler #29
Merged
Node simpler #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into node-simpler
…ys holding BlockClients, fixed array and dynamic functions
…onditional (in main as implemented always evaluates true)
…deredBlockClient struct for easy context id
… when being passed
manager/main.go
Outdated
| if m.miningAvailable[i] { | ||
| m.fetchPendingBlocks(i) | ||
| for _, blockClient := range m.orderedBlockClients { | ||
| if blockClient.chainMining && checkConnection(blockClient.chainAvailable) { |
There was a problem hiding this comment.
Have an explicit check for the current mining slice, even if one of the three clients is not available, we don't even get the pending blocks.
| miningAvailable := make([]bool, 3) | ||
| func getMiningClients(config util.Config) ([]orderedBlockClient, int) { | ||
| allClients := []orderedBlockClient{} | ||
| var intendedCount int = 0 // count how many connections there should be for error checking |
There was a problem hiding this comment.
in golang you dont have to initalize it as zero. It is default as zero.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor that also addresses several issues:
#28
see checkConnection
#26
see orderedBlockClients struct which associates all client properties together