Add support for EIP-1271 contract wallets #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payton
suggested changes
Sep 15, 2022
siwe/siwe.py
Outdated
| @@ -221,7 +235,9 @@ def verify( | |||
| domain: Optional[str] = None, | |||
| nonce: Optional[str] = None, | |||
| timestamp: Optional[datetime] = None, | |||
| provider: Optional[HTTPProvider] = None, | |||
| provider: HTTPProvider = HTTPProvider( | |||
| endpoint_uri="https://cloudflare-eth.com" | |||
There was a problem hiding this comment.
IMO, this feels too opinionated.
siwe/siwe.py
Outdated
| import rfc3987 | ||
| import web3 |
There was a problem hiding this comment.
from web3.exceptions import BadFunctionCallOutput
siwe/siwe.py
Outdated
| hash_ = _hash_eip191_message(message) | ||
| try: | ||
| response = contract.caller.isValidSignature(hash_, bytes.fromhex(signature[2:])) | ||
| return response.hex() == "1626ba7e" |
There was a problem hiding this comment.
nit: add comment explaining what this magicvalue is (from eip: // bytes4(keccak256("isValidSignature(bytes32,bytes)") )
sbihel
force-pushed
the
feat/eip1271
branch
from
78c4d5d
to
17e0ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #16
Close #17