Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the HUGE npm package size of 225MB makes the module less producible #49

Closed
yi opened this issue Feb 23, 2022 · 4 comments
Closed

the HUGE npm package size of 225MB makes the module less producible #49

yi opened this issue Feb 23, 2022 · 4 comments

Comments

@yi
Copy link

yi commented Feb 23, 2022

image

[./node_modules/siwe] -> du -h -d 1
88K	./dist
44K	./lib
24M	./integrations
12K	./.github
24K	./test
294M	./examples
318M	.

The main files take up 44K, while the examples take up 294M. This results in a lot of redundancy with each production deployment. For a service of a certain size, this is a serious obstacle.

Suggestion: take the examples out of the npm package

@sbihel
Copy link
Member

sbihel commented Feb 23, 2022

Apologies, the examples directory was previously excluded but sneaked back into the previous release. @w4ll3 should the integrations be excluded as well?

@w4ll3
Copy link
Member

w4ll3 commented Feb 23, 2022

Not even sure how those folders are in the release, they are no longer in this repo.

@sbihel
Copy link
Member

sbihel commented Feb 23, 2022

Oh I didn't notice integrations was removed from the repo as well. It's just because they're in my local copy

@sbihel sbihel closed this as completed Feb 23, 2022
@wyc
Copy link
Contributor

wyc commented Feb 24, 2022

Thank you so much @yi we love making the release smaller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants