Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum PKH verification method id #297

Closed
clehner opened this issue Sep 16, 2021 · 0 comments · Fixed by #286
Closed

Ethereum PKH verification method id #297

clehner opened this issue Sep 16, 2021 · 0 comments · Fixed by #286

Comments

@clehner
Copy link
Contributor

clehner commented Sep 16, 2021

In did:pkh:eth (to become did:pkh:eip155 in #279 & #286), ssi's implementation uses verification method id #Recovery2020, but the did:pkh spec says it should be #blockchainAccountId.
@ceramicnetwork (@oed)'s implementation ceramicnetwork/js-ceramic#1624 is using the #blockchainAccountId form with did:pkh:eip155.
An implementation could possibly allow both by having the same verification method object twice with different ids.
But maybe since these changes are not yet merged, it would be simpler to change ssi/did-pkh to use #blockchainAccountId with did:pkh:eip155 (and leave did:pkh:eth unchanged).
This was referenced Sep 16, 2021
Merged
Merged
@clehner clehner linked a pull request Sep 16, 2021 that will close this issue
Use CAIP-10 in did:pkh #286
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use CAIP-10 in did:pkh spruceid/ssi
1 participant
@clehner