Use new lds-jws2020 v1 context, conditionally #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clehner
changed the title
This was referenced Oct 18, 2021
clehner
force-pushed
the
feat/lds-jws2020-new
branch
from
af7ce39
to
527309e
Compare
sbihel
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the currently bundled context file (
https://w3c-ccg.github.io/lds-jws2020/contexts/lds-jws2020-v1.json), there is a different one registered under w3id.org:https://w3id.org/security/suites/jws-2020/v1(redirects tohttps://w3c-ccg.github.io/lds-jws2020/contexts/v1). This second, registered one is the one that is used in JWS-Test-Suite. This PR adds it to the repo and updates theJsonWebSignature2020implementation to use it instead of the other one.Additionally, only add the context URI to the newly created proof objects if the parent linked data document doesn't already use this context URI. This is because in JWS-Test-Suite, the input credentials already have the context URI, so adding it again is redundant/unnecessary.