Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EthereumEip712Signature2021 property names #336

Merged
merged 2 commits into from Nov 15, 2021

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Oct 27, 2021

Corresponding to w3c-ccg/ethereum-eip712-signature-2021-spec#32 and w3c-ccg/ethereum-eip712-signature-2021-spec#33

  • Rename messageSchema to types
  • Rename eip712Domain to eip712
  • Allow old way for backwards compatibility
  • Update JSON-LD context file

@clehner clehner force-pushed the feat/eip712sig-type-renaming branch from da4284d to 0b1cc98 Compare October 27, 2021 13:51
@clehner clehner marked this pull request as ready for review November 11, 2021 14:30
@clehner clehner requested a review from sbihel November 11, 2021 14:42
@bumblefudge bumblefudge added this to the v0.3.1 milestone Nov 12, 2021
@bumblefudge
Copy link
Contributor

Downstream instances should update verifiers first, then issuers to insure smooth transition.

- Rename messageSchema to types
- Rename eip712Domain to eip712
- Allow old way for backwards compatibility
@clehner
Copy link
Contributor Author

clehner commented Nov 15, 2021

Rebasing and merging...

@clehner clehner merged commit ecacedf into main Nov 15, 2021
@clehner clehner deleted the feat/eip712sig-type-renaming branch November 15, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants