Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NextAuth support to ssx-react #49

Merged
merged 65 commits into from
Jan 9, 2023
Merged

Conversation

skgbafa
Copy link
Contributor

@skgbafa skgbafa commented Dec 14, 2022

Description

This PR adds support for NextAuth to ssx-react and a corresponding example (ssx-test-nextauth). This PR touches a lot of things! Changes include creating new packages, refactoring ssx-server, and updating ssx-react. Some of the changes were made while debugging next stuff, but were not the eventual solution. I left them in for refactor purposes. I'll highlight them! Please comment on any refactor changes as well as new packages.

Updated packages:

  • ssx-core
  • ssx-server
  • ssx-react

New Packages

  • ssx-server-middleware

Type

  • New feature (non-breaking change which adds functionality)

Diligence Checklist

  • This change requires a documentation update
  • I have included unit tests
  • I have updated and/or included new integration tests
  • I have updated and/or included new end-to-end tests
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

examples/ssx-test-nextauth/pages/index.tsx Outdated Show resolved Hide resolved
packages/ssx-react/src/next.tsx Outdated Show resolved Hide resolved
packages/ssx-react/src/next.tsx Outdated Show resolved Hide resolved
packages/ssx-react/src/ssx.tsx Outdated Show resolved Hide resolved
packages/ssx-sdk/src/core.ts Outdated Show resolved Hide resolved
examples/ssx-test-nextauth/pages/_app.tsx Outdated Show resolved Hide resolved
examples/ssx-test-nextauth/pages/index.tsx Show resolved Hide resolved
examples/ssx-test-nextauth/pages/siwe.tsx Show resolved Hide resolved
packages/ssx-core/src/server/types.ts Show resolved Hide resolved
packages/ssx-react/src/next/frontend.ts Outdated Show resolved Hide resolved
packages/ssx-sdk/src/ssx.ts Show resolved Hide resolved
packages/ssx-server-middleware/package.json Show resolved Hide resolved
packages/ssx-server/src/server.ts Show resolved Hide resolved
scripts/toggle-packages.js Show resolved Hide resolved
@skgbafa skgbafa marked this pull request as ready for review December 20, 2022 18:42
@skgbafa skgbafa requested a review from 44203 December 20, 2022 18:42
examples/ssx-test-nextauth/README.md Outdated Show resolved Hide resolved
examples/ssx-test-nextauth/package.json Outdated Show resolved Hide resolved
packages/ssx-next/src/next.ts Outdated Show resolved Hide resolved
packages/ssx-react/src/next.tsx Outdated Show resolved Hide resolved
examples/ssx-test-nextauth/pages/protected.tsx Outdated Show resolved Hide resolved
packages/ssx-sdk/src/core.ts Outdated Show resolved Hide resolved
packages/ssx-react/src/next/backend.ts Outdated Show resolved Hide resolved
packages/ssx-react/src/next/backend.ts Outdated Show resolved Hide resolved
packages/ssx-react/src/next/frontend.ts Outdated Show resolved Hide resolved
packages/ssx-server-middleware/package.json Show resolved Hide resolved
@Juliano1612
Copy link
Member

Juliano1612 commented Jan 4, 2023

Since this is an implementation for NextAuth, not Next in general, shouldn't we change references to NextAuth? Example: ssx-react/next/frontend -> ssx-react/next-auth/frontend

Copy link
Member

@w4ll3 w4ll3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems good, all we need now is to fix the CI

Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skgbafa skgbafa merged commit 6205fc4 into spruceid:main Jan 9, 2023
sixhobbits pushed a commit to ritza-co/ssx that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants