Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wagmi version support #82

Merged
merged 6 commits into from Feb 23, 2023
Merged

Conversation

w4ll3
Copy link
Member

@w4ll3 w4ll3 commented Feb 13, 2023

Description

This replaces the usage of useSigner hook in the ssx-react package for the watchSigner event listener. This allows for compatibility between all wagmi/rainbow-kit versions.

Type

  • New feature

Diligence Checklist

  • This change requires a documentation update
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

packages/ssx-react/src/ssx.tsx Outdated Show resolved Hide resolved
@w4ll3 w4ll3 changed the title Replace wagmi react hooks for event listeners at ssx-react Improve wagmi version support Feb 22, 2023
@w4ll3 w4ll3 requested a review from skgbafa February 22, 2023 20:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 90.34% // Head: 90.34% // No change to project coverage 👍

Coverage data is based on head (a78b865) compared to base (b1ee1be).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          25       25           
  Lines        3336     3336           
  Branches      270      270           
=======================================
  Hits         3014     3014           
  Misses        322      322           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Juliano1612 Juliano1612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I updated the ssx-test-nextauth-email dependencies (Wagmi and Rainbowkit) to the latest version.

@w4ll3 w4ll3 merged commit 6bbec40 into spruceid:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants