Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssx-quickstart-express example #96

Merged
merged 6 commits into from Feb 28, 2023

Conversation

w4ll3
Copy link
Member

@w4ll3 w4ll3 commented Feb 27, 2023

Description

This introduces a new example to the repository.

Type

  • New feature (non-breaking change which adds functionality)

Diligence Checklist

(Please delete options that are not relevant)

  • This change requires a documentation update
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

@skgbafa skgbafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and we can merge it as is. I left some notes on potential improvements

examples/ssx-quickstart-express/src/index.ts Outdated Show resolved Hide resolved
examples/ssx-quickstart-express/src/index.ts Outdated Show resolved Hide resolved
examples/ssx-quickstart-express/src/index.ts Outdated Show resolved Hide resolved
examples/ssx-quickstart-express/src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Sam Gbafa <skgbafa@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (92f47b0) 90.34% compared to head (e2fec09) 90.34%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   90.34%   90.34%           
=======================================
  Files          25       25           
  Lines        3336     3336           
  Branches      270      270           
=======================================
  Hits         3014     3014           
  Misses        322      322           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@skgbafa skgbafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid!

@obstropolos obstropolos merged commit 2efb331 into spruceid:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants