Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "docker" as recommended folder name #33

Closed
kfrohwein opened this issue Sep 12, 2019 · 4 comments
Closed

Don't use "docker" as recommended folder name #33

kfrohwein opened this issue Sep 12, 2019 · 4 comments

Comments

@kfrohwein
Copy link

I have a "Projects" folder with a lot of projects inside. And I clone your project into it. It's not that useful to have a folder called "docker" if I am looking for the "spryker-docker-sdk" or something like that :)

@marek-obuchowicz
Copy link
Contributor

If you have folder "Projects" and there let's say: "Spryker1", then you should clone spryker-docker-sdk inside your project directory (Projects/Spryker1/docker), not next to your project directory (Projects/docker).

@kfrohwein
Copy link
Author

Yes but the README.md suggest to clone into the folder
git clone https://github.com/spryker/docker-sdk.git ./docker

Sorry if it was not clear what I was talking about. I would change the README.md in that regards.

@kfrohwein
Copy link
Author

Sorry I just re-read #32 I didn't guess that you want me to clone into a spryker installation. In that case the folder name makes sense. I thought that I have to clone this project stand alone for any spryker project I am working on and just use the prepared docker templates.

@marek-obuchowicz
Copy link
Contributor

@kfrohwein thanks for you feedback - we might need to review docs and make sure that it's stated in a more clear and precise way. @sprymiker can you please ask docs team to review this information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants