Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 removes re._pattern_type #1546

Closed
ewdurbin opened this issue Apr 2, 2018 · 1 comment
Closed

Python 3.7 removes re._pattern_type #1546

ewdurbin opened this issue Apr 2, 2018 · 1 comment

Comments

@ewdurbin
Copy link

ewdurbin commented Apr 2, 2018

Ref: python/cpython#1646

Moto uses re._pattern_type in vendored responses library RequestsMock._has_url_match, which has been removed/renamed to re.Pattern as of Python 3.7.

https://github.com/spulec/moto/blob/4184acc0d27b584a921939fb85467cebf27bb025/moto/packages/responses/responses.py#L221

I've filed a report with the upstream project at getsentry/responses#195

Python 3.7.0b3
moto 1.3.1

@spulec
Copy link
Collaborator

spulec commented Apr 12, 2018

Thanks for opening the issue (and all the other amazing work you do for the python community)!

We recently unvendored responses with #1553 so I believe this issue can be closed.

@spulec spulec closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants