Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Tags in Secrets Manager #2004

Closed
norton120 opened this issue Dec 21, 2018 · 3 comments
Closed

Support Tags in Secrets Manager #2004

norton120 opened this issue Dec 21, 2018 · 3 comments

Comments

@norton120
Copy link

Why?

Currently secretsmanager describe_secret returns a hardcoded set of empty tags for the secret. If tags are an important part of your deployment process this breaks :(

What?

persist aTags list passed in create_secret to the describe_secret method.

Who will this help?

  • people who use tags in secrets manager
@sepulworld
Copy link
Contributor

Thanks @norton120 Ill add tags to this PR which is waiting to be merged. #1898

@sepulworld sepulworld mentioned this issue Dec 21, 2018
Merged
@sepulworld
Copy link
Contributor

Added support for tags in #1898

@spulec
Copy link
Collaborator

spulec commented Dec 29, 2018

Closed with #1898

@spulec spulec closed this as completed Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spulec @sepulworld @norton120