Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: remove unnecessary 'datetime' entry #2297

Merged
merged 1 commit into from
Jul 16, 2019
Merged

setup.py: remove unnecessary 'datetime' entry #2297

merged 1 commit into from
Jul 16, 2019

Conversation

yan12125
Copy link
Contributor

This entry is added in [1]. New statements in [1] use the built-in datetime module, which is available since Python 2.3 [2]. On the other hand, when running pip install moto, pip installs Zope Datetime module [3], which is unnecessary.

[1] ed93821
[2] https://docs.python.org/2.7/library/datetime.html
[3] https://pypi.org/project/DateTime/

This entry is added in [1]. New statements in [1] use the built-in datetime module, which is available since Python 2.3 [2]. On the other hand, when running `pip install moto`, pip installs Zope Datetime module [3], which is unnecessary.

[1] ed93821
[2] https://docs.python.org/2.7/library/datetime.html
[3] https://pypi.org/project/DateTime/
@coveralls
Copy link

coveralls commented Jul 12, 2019

Coverage Status

Coverage remained the same at 93.109% when pulling 92bf8ef on yan12125:patch-2 into 396cb39 on spulec:master.

@spulec spulec merged commit e4ed14b into getmoto:master Jul 16, 2019
@spulec
Copy link
Collaborator

spulec commented Jul 16, 2019

thanks!

@yan12125 yan12125 deleted the patch-2 branch July 16, 2019 03:24
svenstaro pushed a commit to archlinux/svntogit-community that referenced this pull request Jul 22, 2020
* The latest version on PyPI is 1.3.11, while it's not an intended release apparently. Git tag 1.3.11 is missing in the upstream repo.
* sshpubkeys is needed since getmoto/moto#2108
* Add dependencies for the moto_server command - python-setuptools in depends and python-flask in optdepends
* Fix sed commands for removing upper bounds of dependencies and make them easier to debug
* The datetime patch is submitted as getmoto/moto#2297

git-svn-id: file:///srv/repos/svn-community/svn@488984 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants