** Merge me first - I fix the build! ** #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of `botocore` (1.19.62) makes changes to the parameter validation code, which for some reason was also covered by a couple of `moto` tests. These tests, when run, do not execute any `moto` code. They fail the parameter validation check in `botocore`, which raises an exception before ever sending a request. These tests do not cover or verify any `moto` behavior and have been removed. Ref: boto/botocore@ff8ae76 Closes getmoto#3627
Nice find @bpandola, thanks for the fix 👍 |
bblommers
approved these changes
Jan 29, 2021
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Feb 9, 2021
… not bump pkgrel as it's only a fix for check() Refs: 1. https://archlinux.org/todo/cleanup-of-python-setuptools-dependency-for-console-scripts/ 2. getmoto/moto#3628 3. getmoto/moto#3610 git-svn-id: file:///srv/repos/svn-community/svn@850819 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Feb 9, 2021
… not bump pkgrel as it's only a fix for check() Refs: 1. https://archlinux.org/todo/cleanup-of-python-setuptools-dependency-for-console-scripts/ 2. getmoto/moto#3628 3. getmoto/moto#3610 git-svn-id: file:///srv/repos/svn-community/svn@850819 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: broken build with release of botocore 1.19.62
The latest release of
botocore(1.19.62) makes changes to the parametervalidation code, which for some reason was also covered by a couple of
mototests.These tests, when run, do not execute any
motocode. They fail theparameter validation check in
botocore, which raises an exceptionbefore ever sending a request. These tests do not cover or verify
any
motobehavior and have been removed.Ref: boto/botocore@ff8ae76
Closes #3627