Skip to content
This repository has been archived by the owner on Apr 25, 2019. It is now read-only.

bump package version #39

Closed
garthk opened this issue Jan 21, 2014 · 4 comments
Closed

bump package version #39

garthk opened this issue Jan 21, 2014 · 4 comments

Comments

@garthk
Copy link

garthk commented Jan 21, 2014

@Marsup, you haven't updated version in package.json since seven commits ago, since which you made breaking changes on master. npm depends on semantic versioning. Please npm version major with all due haste.

@Marsup
Copy link
Contributor

Marsup commented Jan 21, 2014

I do know about semantic versioning, but maybe you forgot that github is not npm, if you want to install github deps do it at your own risk.
npm version major not only bumps package version but also add git tags, so thanks but no thanks.
I do use this command when I'm ready to release though, and most of the node community seems to agree with this way of doing things.

That being said, you can help me validate the good behavior of the next version which is probably finished and currently lies in the badly named branch restyling. Docs will look a bit different from before, hopefully for the better, feedback welcome.

@Marsup
Copy link
Contributor

Marsup commented Jan 21, 2014

Well, after much thoughts, it seems stable enough for a release so I shipped it, you can upgrade your dependency.

@Marsup Marsup closed this as completed Jan 21, 2014
@garthk
Copy link
Author

garthk commented Jan 22, 2014

Woot! Thanks, @Marsup. I'll check restyling shortly; least I can do.

I share your discomfort with npm version mucking around with git tags. npm config set git-tag-version=false disables it, if that helps.

@Marsup
Copy link
Contributor

Marsup commented Jan 22, 2014

No need, the branch is gone to master now :)

There's been a debate over versioning here : https://gist.github.com/nzakas/7633640
I fully agree with Isaac on this one. At the time I didn't know if that work was going to be 1.2 or 2.0, or even whether that would be before or after hapi 2.0, so I didn't take the chance of pre-versioning it.
Since there's no strict guideline about this topic across spumko's projects (correct me if I'm wrong @hueniverse), I'm more comfortable with picking the version that fits best at the time of release.
And anyway, people referring to GH for modules know what they are doing, and the package version probably doesn't even mean something for npm cli when doing this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants