Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs refactoring #4

Closed
KleinerNull opened this issue Aug 26, 2016 · 1 comment
Closed

Needs refactoring #4

KleinerNull opened this issue Aug 26, 2016 · 1 comment

Comments

@KleinerNull
Copy link
Contributor

I was bored and looked into your code. I think it is not a good idea to write the complete code into the __init__.py.

I'd say one can split the _XMLDataset and the parse_using_profile code into seperate sub modules. So it can be easier to extend and change the code in the future.

After you'll have commited your actual changes I would refacture it for you, just don't want to mess with the merging problems now.

@spurin
Copy link
Owner

spurin commented Oct 12, 2016

Agreed, I'm looking into your existing merge requests and feedback on the other areas, after that it should be easier moving forward with other merge requests. Closing this issue for now.

@spurin spurin closed this as completed Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants