Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some avatars do not load properly #9

Closed
spuxx1701 opened this issue Jan 16, 2023 · 2 comments
Closed

Some avatars do not load properly #9

spuxx1701 opened this issue Jan 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@spuxx1701
Copy link
Owner

No description provided.

@spuxx1701 spuxx1701 added the bug Something isn't working label Jan 16, 2023
@spuxx1701 spuxx1701 self-assigned this Jan 16, 2023
@Phillinger
Copy link

Phillinger commented Feb 15, 2023

Not loading properly:

forum.mods.de:

<img src="avatare/oldb/shooter.gif" alt="shooter" class="av " border="0">

test.potber.de:

<img src="https://forum.mods.de/bb/atare/oldb/shooter.gif" alt="☉‿⚆​​" aria-hidden="true">

Notice the missing "av" in the url's "avatare". Seems always to be a problem, if the avatar is stored under "avatare/oldb" without leading slash or dot-slash.

Loading properly:

forum.mods.de:

<img src="./avatare/upload/U59649--lunokl.gif" alt="AUP Lunovis 27.11.2007" class="av " border="0">

test.potber.de:

<img src="https://forum.mods.de/bb/avatare/upload/U59649--lunokl.gif" alt="☉‿⚆​​" aria-hidden="true">

Possible solution:

In getter for avatarUrl the URL's first two chars are sliced away. This is fine, if the URL begins with ./avatare. But if it begins with avatare (like in olddb mentioned above) it invalids the url to atare. Maybe a simple replace() could do the job. Search for "./" at beginning of the string and replace it with "" when found.

/edit: Regexpression should be /^\.\//

@spuxx1701
Copy link
Owner Author

Thanks! ❤
fixed in dc5291d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants