Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FontAwesome to its 5 version #87

Closed
doudz opened this issue Aug 21, 2018 · 3 comments · Fixed by #86
Closed

Update FontAwesome to its 5 version #87

doudz opened this issue Aug 21, 2018 · 3 comments · Fixed by #86
Milestone
v0.5

Comments

@doudz
Copy link
Contributor

doudz commented Aug 21, 2018

Could you update FA to the last version 5.2.0 ?
@darkvertex
Copy link
Contributor

My PR #86 adds support for 5.1.0 but I'm currently blocked by little bug in how the multiple styles are being registered. You're welcome to help me figure it out!

If the little bug goes away I'll be happy to update the PR from 5.1.0 -> 5.2.0

@doudz
Copy link
Contributor Author

doudz commented Aug 24, 2018

See my fix

@darkvertex
Copy link
Contributor

Awesome! I will update my branch to 5.2.0 when I have a bit of time.

@ccordoba12 ccordoba12 added this to the v0.5 milestone Aug 24, 2018
@ccordoba12 ccordoba12 changed the title Update FA to 5.2.0 Update FontAwesome to its 5 version Sep 12, 2018
@darkvertex darkvertex mentioned this issue Sep 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

PR: Update FontAwesome to 5.3.1 darkvertex/qtawesome
3 participants
@ccordoba12 @darkvertex @doudz