New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong old PyQt4 version check #42

Closed

Nodd opened this issue Jun 20, 2016 · 1 comment

Labels

Milestone

Contributor

Nodd commented Jun 20, 2016

Maybe I'm wrong, but it seems to me that is_old_pyqt and is_pyqt46 should use PYQT_VERSION instead of __version__ in https://github.com/spyder-ide/qtpy/blob/master/qtpy/__init__.py#L113. __version__ is now the version of qtpy.

The text was updated successfully, but these errors were encountered:

ccordoba12 added the type:Bug label

ccordoba12 added this to the v1.1 milestone

Member

ccordoba12 commented Jun 20, 2016

That's most probably true, thanks for noticing! Could you make a PR to solve this problem?

Nodd mentioned this issue

Don't check PyQt version with qtpy's version for old PyQt versions #43

Merged

ccordoba12 closed this as completed in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment