Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qInstallMessageHandler <-> qInstallMsgHandler #57

Closed
tobiasgehring opened this issue Aug 13, 2016 · 3 comments
Closed

qInstallMessageHandler <-> qInstallMsgHandler #57

tobiasgehring opened this issue Aug 13, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@tobiasgehring
Copy link
Contributor

The installer for the message handler is called qInstallMsgHandler in PyQt4 and pyside and qInstallMessageHandler in PyQt5. In PyQt5 the message handler got an extra argument called context.

The reason to use qtpy is to have a program running in all three environments. Thus, there should be a unified way to use it (e.g. set context to None if pyqt4/pyside is used).

@goanpeca
Copy link
Member

@tobiasgehring thanks for pointing this out, we will take a look at it.

@goanpeca goanpeca added this to the v1.2 milestone Aug 13, 2016
@goanpeca goanpeca self-assigned this Aug 13, 2016
@ccordoba12
Copy link
Member

@tobiasgehring, could you create a pull request for this? I don't exactly understand what we're supposed to do about this one.

@ccordoba12 ccordoba12 modified the milestones: v1.3, v1.2 Jan 2, 2017
@ccordoba12 ccordoba12 modified the milestones: v1.4, v1.3 May 8, 2017
@goanpeca
Copy link
Member

@rlaverde could you take a look at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants